feat(batch): add batch payment processing - #98
Merged
AbdulmujibOladayo merged 1 commit intoSep 10, 2026
Conversation
|
@mftee is attempting to deploy a commit to the abdulmujiboladayo's projects Team on Vercel. A member of the Team first needs to authorize it. |
AbdulmujibOladayo
approved these changes
Sep 10, 2026
AbdulmujibOladayo
left a comment
AbdulmujibOladayo
left a comment
Contributor
There was a problem hiding this comment.
Good idempotency semantics — same key + same batch ID replays the cached Result instead of reprocessing (important so retries don't double-count), while same key + different batch ID is correctly rejected as key reuse. Per-item validation that rejects bad items without failing the whole batch matches how the architecture doc describes partial batch handling. Same float64-for-money note as #97 — worth a decimal type before this touches real settlement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
internal/batch, a service that validates and processes multiple payment items submitted as one request:Covered by unit tests for valid/invalid items, empty/oversized batches, and idempotent replay.
Closes #57
https://claude.ai/code/session_01AdKUdoVWCGSSDhKvhSKc6J